Skip to content

[Merged by Bors] - chore: CI detects ProofWidgets toolchain mismatch#31723

Closed
kim-em wants to merge 1 commit intoleanprover-community:masterfrom
kim-em:ci-proofwidgets-toolchain-check
Closed

[Merged by Bors] - chore: CI detects ProofWidgets toolchain mismatch#31723
kim-em wants to merge 1 commit intoleanprover-community:masterfrom
kim-em:ci-proofwidgets-toolchain-check

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Nov 16, 2025

See zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/ProofWidgets.20not.20building.2C.20says.20it.20is.20out.20of.20date/near/556720459

Ideally, this would fail right now, demonstrating that it is working, but of course CI only runs from the master version.

Update: now that #31720 is in, this can be merged.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions bot added the CI Modifies the continuous integration setup or other automation label Nov 16, 2025
@github-actions
Copy link
Copy Markdown

PR summary 015b41b4dc

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@bryangingechen
Copy link
Copy Markdown
Contributor

Naïve question: Is proofwidgets the only dependency where this sort of thing needs to be checked? Could this happen with another new dependency that we add in the future?

@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Nov 16, 2025

Naïve question: Is proofwidgets the only dependency where this sort of thing needs to be checked? Could this happen with another new dependency that we add in the future?

So far it is only ProofWidgets, which does some shenanigans that I don't fully understand to retrieve precompiled artifacts so we don't need node installed to build Mathlib.

It's possible that Canonical will have similar difficulties if we ever manage to add that to Mathlib.

@bryangingechen
Copy link
Copy Markdown
Contributor

bryangingechen commented Nov 16, 2025

I just checked a recent commit of mathlib4 master and other than proofwidgets, it looks like LeanSearchClient is also on v4.25.0-rc1. I'm guessing it doesn't matter there and it'd be too strict for us to demand that all .lake/packages/*/lean-toolchain agree with lean-toolchain?

@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Nov 16, 2025

I just checked a recent commit of mathlib4 master and other than proofwidgets, it looks like LeanSearchClient is also on v4.25.0-rc1. I'm guessing it doesn't matter there and it'd be too strict for us to demand that all .lake/packages/*/lean-toolchain agree with lean-toolchain?

Yes, it would be a pain if the really minor libraries that don't depend on much Lean API needed to be bumped every release as well.

@bryangingechen
Copy link
Copy Markdown
Contributor

Thanks!
bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 17, 2025
mathlib-bors bot pushed a commit that referenced this pull request Nov 17, 2025
See zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/ProofWidgets.20not.20building.2C.20says.20it.20is.20out.20of.20date/near/556720459

Ideally, this would fail right now, demonstrating that it is working, but of course CI only runs from the `master` version.

Update: now that #31720 is in, this can be merged.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 17, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: CI detects ProofWidgets toolchain mismatch [Merged by Bors] - chore: CI detects ProofWidgets toolchain mismatch Nov 17, 2025
@mathlib-bors mathlib-bors bot closed this Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants